-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added password prompt for CFund payment/proposal dialogs #474
Conversation
utACK |
Built on Ubuntu 18.04 (I'll do a testnet/devnet test for the functionality) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on devnet, the prompts work for both proposal and payment requests.
ACK tested on debian |
@francisjyap please leave a comment in the original issue with a navcoin address for payment |
@aguycalled the test seems to keep failing (Timeout) Any ideas how to get the travis build to work? |
use travis_wait to extend the test job max execution time |
Looks like it is not possible to extend the job duration to more than 50 min for public repositories using the free version of travis. Any alternatives different from reducing our test units? |
I think if we adjust testnet/devnet so the tests pass faster? Like for example, we can have the static staking reward take only 150 (50 per step) blocks instead of the current 300 (100 per step) And I think the same can be done for cfund tests as well What do you think @aguycalled @craigmacgregor |
Added password prompt for CFund payment/proposal dialogs
This is for issue #457